Differential D3274

add docbook to keditbookmarks
ClosedPublic
Actions

Authored by lueck on Nov 5 2016, 9:30 PM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Commits

R227:ba5d5fdc85ca: add docbook to keditbookmarks

Summary

content moved from konqueror docbook

Test Plan

builds

Diff Detail

Repository

R227 KEditBookmarks

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

lueck updated this revision to Diff 7932.Nov 5 2016, 9:30 PM

lueck retitled this revision from to add docbook to keditbookmarks.

lueck updated this object.

lueck edited the test plan for this revision. (Show Details)

lueck added reviewers: dfaure, Documentation.

lueck set the repository for this revision to R227 KEditBookmarks.

dfaure added inline comments.Nov 6 2016, 10:26 AM

doc/index.docbook
24	not sure what's the relation to kfind?
31	In which application? (probably comes from konqueror, but now it should be generalized, keditbookmarks is also called from many other apps: konsole, konversation, somewhere in digikam...). Maybe prepend "In many applications (e.g. Konqueror, Konsole, Konversation)" ?

address issues pointed out by David, thanks

dfaure accepted this revision.Nov 6 2016, 7:31 PM

dfaure edited edge metadata.

dfaure added inline comments.

doc/index.docbook
33 ↗	(On Diff #7942)	Typo: booksmarks -> bookmarks.

This revision is now accepted and ready to land.Nov 6 2016, 7:31 PM

Closed by commit R227:ba5d5fdc85ca: add docbook to keditbookmarks (authored by lueck). · Explain WhyNov 6 2016, 8:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (3 lines)
A	M		doc/CMakeLists.txt (2 lines)
A	M		doc/index.docbook (97 lines)
M			src/org.kde.keditbookmarks.desktop (68 lines)

Diff 7945

CMakeLists.txt

Loading...

doc/CMakeLists.txt

Loading...

doc/index.docbook

Loading...

src/org.kde.keditbookmarks.desktop

Loading...