Applet: Show device icons and active port name
ClosedPublic

Authored by drosca on Nov 5 2016, 10:20 AM.

Details

Summary

Show the device name in format "Active Port: Device Name" and
icon corresponding to the active port.
Pulseaudio doesn't provide icon names for ports, so there is a hardcoded
set of known port names and their icons. If the port name is not in
this set, icon for device is used instead.

Test Plan

Works fine on my devices. We may want to use different icons or add new icons
so all icons are monochrome though.

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca updated this revision to Diff 7913.Nov 5 2016, 10:20 AM
drosca retitled this revision from to Applet: Show device icons and active port name.
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 5 2016, 10:20 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
colomar added a subscriber: colomar.EditedNov 7 2016, 10:24 PM

Great feature!
I just fear that the naming scheme might make it look like the device name is the name for the port, like "A microphone called Audio Adapter".
Maybe naming
Port (device name)
would make it more clear?

Also: I agree that it should only use monochrome icon. Please request the missing icons from the icon team.

drosca updated this revision to Diff 8025.Nov 8 2016, 3:52 PM

Change label to "PortName (DeviceName)"

drosca added a comment.Nov 8 2016, 3:53 PM

Updated screenshot:

mart accepted this revision.Nov 22 2016, 10:28 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Nov 22 2016, 10:28 AM
This revision was automatically updated to reflect the committed changes.