Differential D3265

Make it possible for 5.8 to compile against the last AppStreamQt
ClosedPublic
Actions

Authored by apol on Nov 4 2016, 5:24 PM.

Details

Reviewers
davidedmundson
rdieter
Group Reviewers
Plasma
Commits
R134:c52df7007183: Make it possible for 5.8 to compile against the last AppStreamQt
R134:18b610278e2b: Move ifdefs to Discover instead of modifying Appstream
Summary

Builds, works. Needs patch in appstream, see pull request

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol updated this revision to Diff 7907.Nov 4 2016, 5:24 PM
apol retitled this revision from to Make it possible for 5.8 to compile against the last AppStreamQt.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: Plasma, rdieter.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 4 2016, 5:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol updated this revision to Diff 8010.Nov 8 2016, 12:08 PM
  • Move ifdefs to Discover instead of modifying Appstream
davidedmundson accepted this revision.Nov 8 2016, 1:05 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Nov 8 2016, 1:05 PM
apol planned changes to this revision.Nov 8 2016, 1:41 PM

Hold your horses... :)

We need some changes still, since the find_package call also changed -.-

Closed by commit R134:c52df7007183: Make it possible for 5.8 to compile against the last AppStreamQt (authored by apol). · Explain WhyNov 10 2016, 5:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8080

View Options

libdiscover/backends/PackageKitBackend/AppPackageKitResource.cpp

Loading...
View Options

libdiscover/backends/PackageKitBackend/CMakeLists.txt

Loading...
View Options

libdiscover/backends/PackageKitBackend/PackageKitBackend.h

Loading...
View Options

libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp

Loading...