Enable JavaScript in QtHelpDocumentation for QCH files from doxygen
ClosedPublic

Authored by kossebau on Nov 4 2016, 11:15 AM.

Details

Summary

Doxygen in newer versions injects hard-coded JavaScript in the QCH files,
for features like dynamic sections. For consistency with Qt Assistant
I would like to propose to allow JavaScript for now.

Fixing doxygen is only at bug reported state currently:
https://bugzilla.gnome.org/show_bug.cgi?id=773715

Test Plan

Add KF5CoreAddons.qch from https://share.kde.org/index.php/s/IuaDnjh704zu5wM
to installed QCH files, "KPluginFactory" and try to toggle display of
dynamic sections like "Public Member Functions inherited from QObject" by
clicking on the ">" symbol or the text.
Works with this patch.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 7894.Nov 4 2016, 11:15 AM
kossebau retitled this revision from to Enable JavaScript in QtHelpDocumentation for QCH files from doxygen.
kossebau updated this object.
kossebau edited the test plan for this revision. (Show Details)
kossebau added reviewers: KDevelop, ochurlaud.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptNov 4 2016, 11:15 AM
antonanikin accepted this revision.Nov 4 2016, 11:44 AM
antonanikin added a reviewer: antonanikin.
antonanikin added a subscriber: antonanikin.

Works well with your test QCH file.

This revision is now accepted and ready to land.Nov 4 2016, 11:44 AM
kfunk accepted this revision.Nov 4 2016, 12:42 PM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.

I don't see why not... To 5.0 branch please.

This revision was automatically updated to reflect the committed changes.