Differential D3253

[desktopgrid] Don't manipulate virtual desktop of desktop window
ClosedPublic
Actions

Authored by graesslin on Nov 4 2016, 8:32 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
KWin
Commits
R108:3c6371390d69: [desktopgrid] Don't manipulate virtual desktop of desktop window
Summary

Desktop Grid has a feature that right or middle clicking a window toggles
the on all desktop state. If that is done for a desktop window, things
obviously start to fail.

KWin internally allows to change virtual desktop for all windows, even
for windows like the desktop or docks. Changing in KWin core is not a
solution.

Thus a special casing in desktop grid is added to disallow the selection
for desktop windows.

BUG: 372037
FIXED-IN: 5.8.4

Test Plan

Tried right clicking desktop window and other windows.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 7881.Nov 4 2016, 8:32 AM
graesslin retitled this revision from to [desktopgrid] Don't manipulate virtual desktop of desktop window.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptNov 4 2016, 8:32 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
mart accepted this revision.Nov 4 2016, 9:58 AM
mart added a reviewer: mart.
mart added a subscriber: mart.

having desktop windows not on all desktops i guess historically is for the old feature of different wallpapers for each desktop

This revision is now accepted and ready to land.Nov 4 2016, 9:58 AM
Closed by commit R108:3c6371390d69: [desktopgrid] Don't manipulate virtual desktop of desktop window (authored by graesslin). · Explain WhyNov 4 2016, 10:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7889

View Options

effects/desktopgrid/desktopgrid.cpp

Loading...