Simplify the window title passed in from the window system
ClosedPublic

Authored by graesslin on Oct 31 2016, 3:01 PM.

Details

Summary

So far KWin used the window title provided from the window directly
without any sanitizing. This could result in broken window decorations
if the title included line breaks. Those were passed to the decoration
and depending on the way how the decoration renders the title, it could
result in visual breakage.

Having line breaks in a window title doesn't make sense. Given that KWin
now simplifies the title when copying it to it's own structure. This
also ensures that the title passed to e.g. task manager does not have
any line breaks on Wayland.

BUG: 323798
FIXED-IN: 5.8.3

Test Plan

Opened the web page in a nested KWin, properly rendered now.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 7782.Oct 31 2016, 3:01 PM
graesslin retitled this revision from to Simplify the window title passed in from the window system.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptOct 31 2016, 3:01 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
hein accepted this revision.Nov 7 2016, 9:24 AM
hein added a reviewer: hein.
This revision is now accepted and ready to land.Nov 7 2016, 9:24 AM
This revision was automatically updated to reflect the committed changes.