Use find_program for cli executables
ClosedPublic
Actions

Authored by elvisangelaccio on Oct 29 2016, 10:26 AM.

Details

Reviewers

Commits

R36:6fca7438f1d2: cmake: use find_program for cli executables

Summary

cmake can look for a given executable with the find_program macro. We can use
it to print warnings in the cmake output when an executable is not installed.

Test Plan

Run cmake and check the output.

Diff Detail

Repository

R36 Ark

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio updated this revision to Diff 7746.Oct 29 2016, 10:26 AM

elvisangelaccio retitled this revision from to Use find_program for cli executables.

elvisangelaccio updated this object.

elvisangelaccio edited the test plan for this revision. (Show Details)

elvisangelaccio added a reviewer: rthomsen.

Restricted Application added a project: Ark. · View Herald TranscriptOct 29 2016, 10:26 AM

Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript

Please also check for the lrzip executable.

This revision now requires changes to proceed.Nov 2 2016, 5:32 AM

Also look for lrzip

Ship it! :)

This revision is now accepted and ready to land.Nov 5 2016, 10:51 AM

Closed by commit R36:6fca7438f1d2: cmake: use find_program for cli executables (authored by elvisangelaccio). · Explain WhyNov 5 2016, 10:57 AM

This revision was automatically updated to reflect the committed changes.

elvisangelaccio mentioned this in R36:6fca7438f1d2: cmake: use find_program for cli executables.

Revision Contents
Changeset List

			Path	Packages
M			plugins/cli7zplugin/CMakeLists.txt (7 lines)
M			plugins/clirarplugin/CMakeLists.txt (14 lines)
M			plugins/cliunarchiverplugin/CMakeLists.txt (7 lines)
M			plugins/clizipplugin/CMakeLists.txt (14 lines)
M			plugins/libarchive/CMakeLists.txt (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7746	efa2636		Oct 29 2016, 10:26 AM	★	★
Diff 2	7915	1b5af86	- Also look for lrzip	Nov 5 2016, 10:38 AM	★	★
Diff 3	7917	9f3e851	rARK6fca7438f1d27b949015f366b65ec9e23ad2296b	Nov 5 2016, 10:54 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
22d29182ac93	2746a051b208	cb3f538951f8	Elvis Angelaccio	Also look for lrzip	Nov 5 2016, 10:38 AM
cb3f538951f8	303b965362d6	1b5af864b225	Elvis Angelaccio	Use find_program for cli executables (Show More…)	Oct 29 2016, 10:23 AM