Differential D318

DataSourceQueriesTest Porting to fake: shouldNotCrashDuringFindSearchTopLevelWhenFetchJobFailedOrEmpty
ClosedPublic
Actions

Authored by franckarrecot on Aug 29 2015, 11:17 AM.

Details

Reviewers
bensi
ervin
remibenoit
Commits
R4:03f52d46277f: DataSourceQueriesTest Porting to fake…

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
franckarrecot updated this revision to Diff 668.Aug 29 2015, 11:17 AM
franckarrecot retitled this revision from to DataSourceQueriesTest Porting to fake: shouldNotCrashDuringFindSearchTopLevelWhenFetchJobFailedOrEmpty.
franckarrecot updated this object.
franckarrecot edited the test plan for this revision. (Show Details)
franckarrecot added reviewers: ervin, bensi, remibenoit.
ervin accepted this revision.Sep 2 2015, 5:54 PM
ervin edited edge metadata.

Accepted, note however that since you went the "one patch per method" route, this can't be the last patch of the series. You need an extra patch to cleanup the includes and using namespace after that one.

This revision is now accepted and ready to land.Sep 2 2015, 5:54 PM
franckarrecot updated this revision to Diff 735.Sep 5 2015, 11:58 AM
franckarrecot edited edge metadata.

o

franckarrecot added a comment.Sep 5 2015, 12:00 PM

nothing change here; no worry, my bad.

ervin added a comment.Sep 6 2015, 2:08 PM

Please don't forget you need another patch in your series after that one, its sole purpose will be to clean the includes in that test class!

ervin requested changes to this revision.Sep 7 2015, 7:49 AM
ervin edited edge metadata.

Since I still didn't see anything happen to address my comment, I'll mark that one as blocked... I suspect my repeated comments went unnoticed.

You need an extra patch to cleanup the includes and using namespace after that one. I'll mark this one accepted when said patch appears.

This revision now requires changes to proceed.Sep 7 2015, 7:49 AM
franckarrecot added a comment.Sep 7 2015, 8:08 AM

wow totally miss that

ervin accepted this revision.Sep 7 2015, 8:28 AM
ervin edited edge metadata.
This revision is now accepted and ready to land.Sep 7 2015, 8:28 AM
Closed by commit R4:03f52d46277f: DataSourceQueriesTest Porting to fake… (authored by franckarrecot). · Explain WhySep 7 2015, 8:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 816

View Options

tests/units/akonadi/akonadidatasourcequeriestest.cpp

Loading...