Differential D332

DataSourceQueriesTest Ported to fake, last clean up
ClosedPublic
Actions

Authored by franckarrecot on Sep 7 2015, 8:25 AM.

Details

Reviewers
ervin
Commits
R4:93b6ac0ceb6d: DataSourceQueriesTest Ported to fake, last clean up
Summary

Reorganize in alphabetical order and get rid of useless include

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
franckarrecot updated this revision to Diff 779.Sep 7 2015, 8:25 AM
franckarrecot retitled this revision from to DataSourceQueriesTest Ported to fake, last clean up.
franckarrecot updated this object.
franckarrecot edited the test plan for this revision. (Show Details)
franckarrecot added a reviewer: ervin.
ervin requested changes to this revision.Sep 7 2015, 8:30 AM
ervin edited edge metadata.
ervin added inline comments.
tests/units/akonadi/akonadidatasourcequeriestest.cpp
26–27

Keep that one first still.

We try (and sometimes fail but here I spotted it) to have the "system" includes first, then the project ones.

This revision now requires changes to proceed.Sep 7 2015, 8:30 AM
franckarrecot updated this revision to Diff 780.Sep 7 2015, 11:51 AM
franckarrecot edited edge metadata.

update

ervin requested changes to this revision.Sep 7 2015, 11:57 AM
ervin edited edge metadata.

Couple of extra cleanups you can do and I didn't spot the first time. Sorry about that.

Almost there!

tests/units/akonadi/akonadidatasourcequeriestest.cpp
27

Not needed.

30–32

Not needed anymore

This revision now requires changes to proceed.Sep 7 2015, 11:57 AM
franckarrecot updated this revision to Diff 782.Sep 7 2015, 1:46 PM
franckarrecot edited edge metadata.

last one ?

ervin requested changes to this revision.Sep 7 2015, 1:55 PM
ervin edited edge metadata.
ervin added inline comments.
tests/units/akonadi/akonadidatasourcequeriestest.cpp
33

You forgot to remove that one. ;-)

This revision now requires changes to proceed.Sep 7 2015, 1:55 PM
franckarrecot updated this revision to Diff 784.Sep 7 2015, 4:24 PM
franckarrecot edited edge metadata.

last one !

ervin accepted this revision.Sep 7 2015, 5:00 PM
ervin edited edge metadata.

At last! You can push. :-)

This revision is now accepted and ready to land.Sep 7 2015, 5:00 PM
Closed by commit R4:93b6ac0ceb6d: DataSourceQueriesTest Ported to fake, last clean up (authored by franckarrecot). · Explain WhySep 7 2015, 8:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 817

View Options

tests/units/akonadi/akonadidatasourcequeriestest.cpp

Loading...