Improve error handling for CliPlugins
ClosedPublic
Actions

Authored by rthomsen on Oct 23 2016, 3:30 PM.

Details

Reviewers

Commits

R36:702468a11f12: Improve error handling for CliPlugins

Summary

This diff removes the ExtractionFailedPatterns regexp in CliProperties. Instead we take care of the error handling in the individual plugins by adding a pure virtual readExtractLine() method to CliInterface (similar to readListLine()). This way we can provide custom error messages to Part, instead of the generic Extraction failed due to an unexpected error (this message was also used for ListJob).

Test Plan

Test listing or extracting archives handled by CliPlugins with some error.

Multi-volume RAR archive with a missing volume.
Open Zip archive using Xz compression with clizip.
Open AES-encrypted Zip archive with clizip.

Diff Detail

Repository

R36 Ark

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

rthomsen updated this revision to Diff 7621.Oct 23 2016, 3:30 PM

rthomsen retitled this revision from to Improve error handling for CliPlugins.

rthomsen updated this object.

rthomsen edited the test plan for this revision. (Show Details)

rthomsen added a reviewer: elvisangelaccio.

rthomsen set the repository for this revision to R36 Ark.

rthomsen added a project: Ark.

Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptOct 23 2016, 3:30 PM

rthomsen updated this revision to Diff 8118.Nov 13 2016, 2:27 PM

rthomsen updated this object.

rthomsen edited the test plan for this revision. (Show Details)

elvisangelaccio requested changes to this revision.Nov 13 2016, 2:41 PM

elvisangelaccio edited edge metadata.

elvisangelaccio added inline comments.

plugins/cliunarchiverplugin/cliplugin.cpp
98	Let's remove the "Segmentation fault" pattern so you don't have to use a QVector here.
114	Same, drop "Segmentation fault"

This revision now requires changes to proceed.Nov 13 2016, 2:41 PM

Remove the "Segmentation fault" regexp in cliunarchiverplugin, so we don't need the QVector.
Clizip: Fix detection of unsupported compression method.

rthomsen marked 2 inline comments as done.Nov 13 2016, 6:16 PM

elvisangelaccio accepted this revision.Nov 13 2016, 8:12 PM

elvisangelaccio edited edge metadata.

This revision is now accepted and ready to land.Nov 13 2016, 8:12 PM

Closed by commit R36:702468a11f12: Improve error handling for CliPlugins (authored by rthomsen). · Explain WhyNov 15 2016, 4:24 PM

This revision was automatically updated to reflect the committed changes.

rthomsen mentioned this in R36:702468a11f12: Improve error handling for CliPlugins.

Revision Contents
Changeset List

			Path	Packages
M			kerfuffle/cliinterface.h (1 line)
M			kerfuffle/cliinterface.cpp (15 lines)
M			kerfuffle/cliproperties.h (3 lines)
M			kerfuffle/cliproperties.cpp (10 lines)
M			plugins/cli7zplugin/cliplugin.h (1 line)
M			plugins/cli7zplugin/cliplugin.cpp (21 lines)
M			plugins/clirarplugin/cliplugin.h (1 line)
M			plugins/clirarplugin/cliplugin.cpp (31 lines)
M			plugins/cliunarchiverplugin/cliplugin.h (1 line)
M			plugins/cliunarchiverplugin/cliplugin.cpp (31 lines)
M			plugins/clizipplugin/cliplugin.h (1 line)
M			plugins/clizipplugin/cliplugin.cpp (19 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7621			Oct 23 2016, 3:20 PM	★	★
Diff 2	8118			Nov 13 2016, 10:04 AM	★	★
Diff 3	8123			Nov 13 2016, 6:14 PM	★	★
Diff 4	8171	f399eaa	rARK702468a11f12d20b828c54785e92bdea7d254185	Nov 15 2016, 4:13 PM	★	★