Differential D3139

Fix aborting libarchive jobs
ClosedPublic
Actions

Authored by elvisangelaccio on Oct 23 2016, 12:06 PM.

Details

Reviewers
rthomsen
Commits
R36:9edb02c22feb: libarchive: don't hang when aborting read-write jobs
Summary

On master libarchive code changed a lot. Now we have a single
ReadWriteLibarchivePlugin::processOldEntries() that copies the old archive
being modified.
However the while() loop in that method has a wrong check in the entering condition.
This prevents at least DeleteJobs from being aborted.

Test Plan

Try to stop a DeleteJob with and without patch.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 7616.Oct 23 2016, 12:06 PM
elvisangelaccio retitled this revision from to Fix aborting libarchive jobs.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptOct 23 2016, 12:06 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
elvisangelaccio added a comment.Oct 23 2016, 12:17 PM

MoveJobs/CopyJobs are also affected by the bug and fixed by this patch.

rthomsen accepted this revision.Oct 23 2016, 12:39 PM
rthomsen edited edge metadata.

Ship it!

This revision is now accepted and ready to land.Oct 23 2016, 12:39 PM

Revision Contents
Changeset List

Diff 7619

View Options

plugins/libarchive/readwritelibarchiveplugin.cpp

Loading...