Differential D3137

Fix crash when aborting an ExtractJob with CliInterface
ClosedPublic
Actions

Authored by elvisangelaccio on Oct 23 2016, 9:52 AM.

Details

Reviewers
rthomsen
Commits
R36:5e61417e02b2: cliinterface: fix crash when aborting an ExtractJob
Summary

CliInterface::copyProcessFinished() doesn't check the m_abortingOperation flag,
so finished() gets always emitted. At this point the Part is already gone, so Ark
crashes.

Test Plan

Stop an ExtractJob with a cliplugin.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 7612.Oct 23 2016, 9:52 AM
elvisangelaccio retitled this revision from to Fix crash when aborting an ExtractJob with CliInterface.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptOct 23 2016, 9:52 AM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen accepted this revision.Oct 23 2016, 10:28 AM
rthomsen edited edge metadata.

Nice work :)

This revision is now accepted and ready to land.Oct 23 2016, 10:28 AM

Revision Contents
Changeset List

PathPackages
Mkerfuffle/cliinterface.cpp (5 lines)

Diff 7614

View Options

kerfuffle/cliinterface.cpp

Loading...