Differential D3129

Fix data loss when aborting jobs in readwritelibarchive plugin
ClosedPublic
Actions

Authored by elvisangelaccio on Oct 21 2016, 12:58 PM.

Details

Reviewers
rthomsen
Commits
R36:d1444e74574d: libarchive: fix data loss when aborting AddJobs and Deletejobs
Summary

Currently there is data loss when we abort an AddJob or DeleteJob with the
libarchive plugin. This happens because we always call commit() on the QSaveFile.

With this patch we call commit() only when we are not aborting (killing) the job.

BUG: 365869
FIXED-IN: 16.08.3

Test Plan
  • Close Ark during an AddJob or DeleteJob on a huge tar archive.
  • Make sure the archive is not changed.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 7593.Oct 21 2016, 12:58 PM
elvisangelaccio retitled this revision from to Fix data loss when aborting jobs in readwritelibarchive plugin.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptOct 21 2016, 12:58 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen accepted this revision.Oct 23 2016, 9:14 AM
rthomsen edited edge metadata.

Fixes the bug for me :)

This revision is now accepted and ready to land.Oct 23 2016, 9:14 AM

Revision Contents
Changeset List

Diff 7611

View Options

plugins/libarchive/readwritelibarchiveplugin.cpp

Loading...