I propose to move these two lines to KReportItemBase::Private ctor's initializer. Such approach will also remove COVERITY warnings about uninitialized members if I remember correctly (COVERITY has no idea about d-pointer tricks).

Let's use nameProperty for more clear meaning.

This line can be also moved to the KReportItemBase::Private ctor.

Memory leak, missing delete d

Hmm! Since we no longer constructing property set instance in subclasses, we can move this code directly to the KReportItemBase::Private ctor, remove this method, and have so much code removed in all files (all new KPropertySet calls and all addDefaultProperties() calls).

Finally, we can own the property set at the level of KReportItemBase so how about having it declared as KPropertySet set in the KReportItemBase::Private class so we don't need to play with memory? All 'delete m_set` calls can be removed as well then.

I propose to change to

KPropertySet* propertySet();

and add

const KPropertySet* propertySet() const;

Not needed, we already have KPropertySet* propertySet()

QString &oldName() -> QString oldName() const

Hmm, for obtaining the values we already have

KReportPosition position() const;
KReportSize size() const;

For setting let's add protected setters.

+Q_DECL_HIDDEN

We already do that in superclass.

By the way I propose further simplification by adding an empty protected Q_SLOT:

virtual void KReportItemBase::propertyChanged(KPropertySet &s, KProperty &p)

And moving the connect() to KReportItemBase.

Note the virtual here. Subclasses can reimplement the method without adding any connect() -- 14 occurences can be removed. And because KReportItemBase::propertyChanged() is empty, it does not need to be called from the reimplementation.

Maybe it's name is in init(scene, d)?

Like above.

based on the changes I propose the line could be:

QPointF original = position().toScene();

based on the changes I propose the line could be:

setPosition(original);

let's remove them

let's remove them

Let's keep all methods on top before any members

Doesn't KPropertySet own and destroy properties?

Let's use new connection API

is this method needed?

Let's use full name size

I think this line is a bit too redundant

Not QSizeF size() const?

& not needed

I think this line is a bit too redundant

Why not Q_SLOT?

Like above re const

can we remove now?

can we remove now?

(KPropertySet &s, KProperty &p)

->nameProperty

would it go to Private?

Not sure but maybe zValue like in QGraphicsItem::zValue?

Or z like in QQuickItem::z?