Differential D3098

Update screen pool connector ID ordering before adjusting desktop containments
ClosedPublic
Actions

Authored by davidedmundson on Oct 18 2016, 11:15 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R120:9331001f4a97: Update screen pool connector ID ordering before adjusting desktop containments
R871:9331001f4a97: Update screen pool connector ID ordering before adjusting desktop containments
Summary

Setting the screenpool primary screen changes the mapping of ID ->
connector. We need this to be done before the
DesktopView::setScreenToFollow is called because otherwise it will save
lastScreen with the wrong ID.

BUG: 370711 (?)

Test Plan

Hot swapped primary, both things swapped.
Restarted Plasma
Things restored as I think they should be.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 7506.Oct 18 2016, 11:15 AM
davidedmundson retitled this revision from to Update screen pool connector ID ordering before adjusting desktop containments.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 18 2016, 11:15 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a subscriber: mart.Oct 18 2016, 4:18 PM

in general, it's OK.
But as this is a bit delicate part, can you do one more test?

have only the external screen enabled and primary, then detaching and reattaching the cable from the connector.
this is a similar but not completely code path to swapping the primary screen.

mart accepted this revision.Oct 27 2016, 8:13 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Oct 27 2016, 8:13 AM
Closed by commit R120:9331001f4a97: Update screen pool connector ID ordering before adjusting desktop containments (authored by davidedmundson). · Explain WhyOct 27 2016, 9:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/shellcorona.cpp (3 lines)

Diff 7708

View Options

shell/shellcorona.cpp

Loading...