OpenProjectDialog support for filename
ClosedPublic

Authored by enniob on Oct 16 2016, 9:07 PM.

Details

Summary

Currently if the user selects a folder while importing a project, the "open project" dialog will show a list of all the (projectfile, project managers) pair that can be used.
For example, if we select a directory with t1.pro and t2.pro, we get two entries for qmake, one for t1.pro and the other for t2.pro, along with the entry for "Generic Project Manager", etc.

However, all the selections are equivalent, as OpenProjectDialog::selectedUrl always returns the folder name, and not the selected .pro file. This patch attempts to fix this issue.

Diff Detail

Repository
R33 KDevPlatform
Lint
Lint Skipped
Unit
Unit Tests Skipped
enniob updated this revision to Diff 7425.Oct 16 2016, 9:07 PM
enniob retitled this revision from to OpenProjectDialog support for filename.
enniob updated this object.
enniob edited the test plan for this revision. (Show Details)
enniob added a reviewer: KDevelop.
enniob set the repository for this revision to R33 KDevPlatform.
enniob added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. ยท View Herald TranscriptOct 16 2016, 9:07 PM
brauch accepted this revision.Oct 16 2016, 10:08 PM
brauch added a reviewer: brauch.
brauch added a subscriber: brauch.

Looks good to me, thanks for the patch. Do you need this in 5.0? Otherwise I would suggest to push it to master only, simply because it's not a bug fix.

You don't have write access to the KDE repos yet, I assume ...?

This revision is now accepted and ready to land.Oct 16 2016, 10:08 PM

Hey,
Master only is fine, I don't have write access to the repo.

kfunk added a subscriber: kfunk.Oct 20 2016, 10:41 AM

@brauch Please push if you think this patch is okay.

brauch closed this revision.Nov 3 2016, 5:53 PM

Submitted, and again I don't understand why it wasn't closed automatically ...