Allow extraction of read-only archives
ClosedPublic

Authored by elvisangelaccio on Oct 16 2016, 5:09 PM.

Details

Summary

We use KFileItemListProperties::supportsWriting() to check whether a folder
is read-write and can be used as extract destination, but this function returns
false if the archive is read-only. A read-only archive can still be extracted,
so we need to implement our own check for the writability of parent folders.

Test Plan

Check that https://bugs.kde.org/show_bug.cgi?id=370948 is fixed.
Check that the action is still disabled in read-only folders.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio retitled this revision from to Allow extraction of read-only archives.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptOct 16 2016, 5:09 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen accepted this revision.Oct 17 2016, 7:53 PM
rthomsen edited edge metadata.

Fixes the bug for me.

This revision is now accepted and ready to land.Oct 17 2016, 7:53 PM
This revision was automatically updated to reflect the committed changes.