Port away from KDELibs4Support
ClosedPublic

Authored by davidk on Oct 16 2016, 12:31 PM.

Details

Test Plan

Builds and works fine, including the password dialog.

Diff Detail

Repository
R128 User Manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidk updated this revision to Diff 7421.Oct 16 2016, 12:31 PM
davidk retitled this revision from to Port away from KDELibs4Support.
davidk updated this object.
davidk edited the test plan for this revision. (Show Details)
davidk added a reviewer: Plasma.
davidk added a project: Plasma.
davidk added a subscriber: plasma-devel.
mart accepted this revision.Oct 17 2016, 9:31 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Oct 17 2016, 9:31 AM
This revision was automatically updated to reflect the committed changes.
apol added a subscriber: apol.Oct 23 2016, 3:04 PM

Other than that, LGTM.

src/passworddialog.cpp
65

It's better to use the dialog box directly, rather than accessing the buttons:

connect(buttonBox, &QDialogButtonBox::accepted, dialog, &QDialog::accept);
connect(buttonBox, &QDialogButtonBox::rejected, dialog, &QDialog::reject);
davidk marked an inline comment as done.Oct 25 2016, 8:00 AM

Thanks for pointing this out, pushed in a separate commit.