Fix KF5 port.
ClosedPublic

Authored by xuetianweng on Oct 15 2016, 1:30 AM.

Details

Summary

check of HAVE_CDDA_IOCTL_DEVICE is wrongly removed during port, restore
it and replace usages of deprecated cmake macro with new one.

Also QUrl::query() and KUrl::query() behaves differently, while QUrl::query()
will not return '?' in return value.

Test Plan

Test with a real CD localily.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
xuetianweng updated this revision to Diff 7403.Oct 15 2016, 1:30 AM
xuetianweng retitled this revision from to Fix KF5 port..
xuetianweng updated this object.
xuetianweng edited the test plan for this revision. (Show Details)
xuetianweng added reviewers: lesliezhai, whiting.
lesliezhai accepted this revision.Oct 17 2016, 2:25 AM
lesliezhai edited edge metadata.

Hi wuetian,

Sorry I did not test audiocd-kio for REAL driver device and Audio CD, but often used CDEmu as the Test enviroment at very begining http://www.leetcode.cn/2016/08/k3b.html

But later I tested K3B rip AudioCD, it works well ;-)

Thanks for your patch, you are able to git push to audiocd-kio repos! please ship it, it looks good to me ;-)

Regards,
Leslie Zhai

This revision is now accepted and ready to land.Oct 17 2016, 2:25 AM
xuetianweng closed this revision.Oct 17 2016, 3:18 AM