Differential D3001

Avoid calling resize() with our current size
ClosedPublic
Actions

Authored by davidedmundson on Oct 10 2016, 10:53 AM.

Details

Reviewers
bshah
Group Reviewers
Plasma
Commits
R871:fbd11d8025ac: Avoid calling resize() with our current size
R120:fbd11d8025ac: Avoid calling resize() with our current size
Summary

resize(size()) does not no-op in QWindow, and actually processes the
resizing. This performs a check that the action is valid.

Test Plan

Resized my panel, all seemed to still work.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 7255.Oct 10 2016, 10:53 AM
davidedmundson retitled this revision from to Avoid calling resize() with our current size.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 10 2016, 10:53 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bshah accepted this revision.Oct 10 2016, 11:13 AM
bshah added a reviewer: bshah.
bshah added a subscriber: bshah.

yep.. no more positionPanel call..

This revision is now accepted and ready to land.Oct 10 2016, 11:13 AM
Closed by commit R120:fbd11d8025ac: Avoid calling resize() with our current size (authored by l10n daemon script <scripty@kde.org>, committed by davidedmundson). · Explain WhyOct 10 2016, 11:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/panelview.cpp (26 lines)

Diff 7257

View Options

shell/panelview.cpp

Loading...