Detect error when unrar version is too old
ClosedPublic
Actions

Authored by rthomsen on Oct 9 2016, 11:03 AM.

Details

Reviewers

Commits

R36:a3921c6ceced: clirar: Detect error when unrar version is too old

Summary

Unrar 3 and 4 cannot open RAR5 archives. Currently, when opening a RAR5 archive with these old versions there is an uncaught error message which ends up in the comment widget.

This diff adds a check for these error messages in clirar and emits an error signal with a proper message.

CliInterface was changed so that handleLine() passes on the boolean return value of readListLine() to readStdOut(). This way, we can stop readStdOut() from handling further lines when readListLine() returns false. This was needed to avoid multiple error signals being emitted. Previously, the return value of readListLine() was unused.

Unittests were added for both unrar 3 and 4.

Test Plan

Install unrar v3 and v4.
Open a RAR5 archive (these can be created with -ma5 switch).
Check that error messages are shown in the KMessageWidget and not in comment field.

Diff Detail

Repository

R36 Ark

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

rthomsen updated this revision to Diff 7227.Oct 9 2016, 11:03 AM

rthomsen retitled this revision from to Detect error when unrar version is too old.

rthomsen updated this object.

rthomsen edited the test plan for this revision. (Show Details)

rthomsen added a reviewer: elvisangelaccio.

rthomsen set the repository for this revision to R36 Ark.

rthomsen added a project: Ark.

Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptOct 9 2016, 11:03 AM

elvisangelaccio requested changes to this revision.Oct 9 2016, 1:05 PM

elvisangelaccio edited edge metadata.

elvisangelaccio added inline comments.

autotests/plugins/clirarplugin/clirartest.cpp
223	Use `.toString()` instead of `value<QString>()`, according to clazy the latter generates more code because there is a template instantiation
plugins/clirarplugin/cliplugin.cpp
316	Please remove this commented line
324	here too

This revision now requires changes to proceed.Oct 9 2016, 1:05 PM

Implement Elvis' suggestions.

rthomsen marked 3 inline comments as done.Oct 9 2016, 3:53 PM

elvisangelaccio accepted this revision.Oct 9 2016, 4:12 PM

elvisangelaccio edited edge metadata.

This revision is now accepted and ready to land.Oct 9 2016, 4:12 PM

Closed by commit R36:a3921c6ceced: clirar: Detect error when unrar version is too old (authored by rthomsen). · Explain WhyOct 9 2016, 4:35 PM

This revision was automatically updated to reflect the committed changes.

rthomsen mentioned this in R36:a3921c6ceced: clirar: Detect error when unrar version is too old.

Revision Contents
Changeset List

		Path
M		autotests/plugins/clirarplugin/clirartest.cpp (59 lines)
A	M	autotests/plugins/clirarplugin/data/archive-RARv5-unrar3.txt (4 lines)
A	M	autotests/plugins/clirarplugin/data/archive-RARv5-unrar4.txt (5 lines)
M		kerfuffle/cliinterface.cpp (3 lines)
M		plugins/clirarplugin/cliplugin.h (5 lines)
M		plugins/clirarplugin/cliplugin.cpp (67 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7227			Oct 9 2016, 10:51 AM	★	★
Diff 2	7232			Oct 9 2016, 3:52 PM	★	★
Diff 3	7233	e399dc7	rARKa3921c6ceced49499ac024d0ae67563275eaadb6	Oct 9 2016, 4:33 PM	★	★