Since the port to KConfigXT, the setting "placement" is stored using the enum value, instead of a string equivalent.
This updates the kcm model to be able to communicate this property with the config schema.
BUG: 421586
FIXED-IN: 5.19.0
Details
Details
- Reviewers
zzag - Group Reviewers
KWin Plasma - Commits
- R108:fdd9ed53d9a6: [kcm/kwinrules] Fix Placement setting
- In a rule set the "Initial Placement" property
- The value is stored in ~/.config/kwinrulesrc
- Close/reopen the kcm. The placement value is correctly loaded.
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
The setting "placement" is now stored usign the enum value, instead of a string equivalent
This will break the placement window rule for existing users, won't it? We either need a kconf_update script to replace strings with enum values or just continue using strings.
Comment Actions
Sorry, I phrased it wrong. The change to use the enum instead of strings in the settigs was done before the new kcm, in the port to KconfigXT. This just updates the kcm to it since it's not working (it can not read/write the placement from the settings schema)
EDIT: For what I've gather, the kconf_update script would still be required to update previous configs, independently of this patch, since the change is also new to 5.19.
Comment Actions
Okay, I see. We still probably need a kconf_update script, but it would be unrelated to what this change intends to do.