[KJots] Drop LocalResourceCreator
ClosedPublic

Authored by poboiko on Fri, May 15, 10:42 AM.

Details

Summary

As I understood, the "create-resource-on-first-start" routine was part of migration to Akonadi process
back in KDE4 times. Now there is firstrun routine in Akonadi and defaultsetup in kdepim-runtime,
which creates default resources including Akonotes.

I think it should be safe to drop it from KJots.
Well, at least I don't see similar routines in other KDEPIM applications.

Since we now use StandardActionManager, we now can also provide user with an action to create a new resource
directly from KJots (if for some reason user don't have default one set up)

Test Plan

make

Diff Detail

Repository
R573 KJots
Branch
auto-create (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26992
Build 27010: arc lint + arc unit
poboiko created this revision.Fri, May 15, 10:42 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptFri, May 15, 10:42 AM
poboiko requested review of this revision.Fri, May 15, 10:42 AM

I suppose KJots should now install a new desktopfile to the defaultsetup directory, so that a Notes resource is created by default when user installs KJots?

I suppose KJots should now install a new desktopfile to the defaultsetup directory, so that a Notes resource is created by default when user installs KJots?

There is already an akonadi_akonotes_resource default resource installed with kdepim-runtime, and I was wondering if it would be sufficient.
We probably don't want two "Notes" resource to be created (or how does it work?).

poboiko updated this revision to Diff 82997.Sat, May 16, 11:53 AM

Remove dependency on no longer existent target noteshared_settings_xml

dvratil accepted this revision.Mon, May 18, 11:30 AM

Ok, I didn't notice it there, sorry.

This revision is now accepted and ready to land.Mon, May 18, 11:30 AM
poboiko closed this revision.Mon, May 18, 3:35 PM