[Notifications] Don't take updated time into account for sorting
ClosedPublic

Authored by broulik on Fri, May 15, 8:37 AM.

Details

Summary

Notification spec says, when replacing a notification:

The server must atomically (ie with no flicker or other visual cues) replace the given notification with this one.

Notifications shifting about is a "visual cue".

Test Plan

I've noticed that with D29770 where I always update notification text, notification can randomly swap places depending on which free space job happened to be finished first.

Since this is a "fix to make it more spec compliant", could go into 5.18? Definitely should go into 5.19

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Fri, May 15, 8:37 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, May 15, 8:37 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Fri, May 15, 8:37 AM
ngraham accepted this revision.Mon, May 18, 2:54 PM
ngraham added a subscriber: ngraham.

Makes sense.

This revision is now accepted and ready to land.Mon, May 18, 2:54 PM
This revision was automatically updated to reflect the committed changes.