Modify the kwinscreenedges KCM to also list scripts which support screen
edge activation and read/write the appropriate value in the script's
config.
In order to only show relevant scripts an additional .desktop metadata
field is added.
Details
Details
- Reviewers
graesslin - Group Reviewers
Plasma - Commits
- R108:4bb12f3f010d: Allow configuring script's screen edges from the KCM
Opened KCM set a hot corner for minimize all.
Tested it
unset it, and set on another corner
Tested again
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| kcmkwin/kwinscreenedges/main.cpp | ||
|---|---|---|
| 96–97 | nitpick | |
| 211 | Why are you querying KService? Scripts are packages and at least KWin internally they are queried using: KPackage::PackageLoader::self()->listPackages(QStringLiteral("KWin/Script"), scriptFolder); | |
| 215 | please don't add any new foreach any more. It might get deprecated | |
| 331 | same here | |
| kcmkwin/kwinscreenedges/main.cpp | ||
|---|---|---|
| 211 | it's copy paste from kcm_kwinscripts If you are doing that in kwin you have a bug as you're ignoring the KWin-Exclude-Listing flag and potentially loading things that you can't configure. | |
| kcmkwin/kwinscreenedges/main.cpp | ||
|---|---|---|
| 211 |
KWin-Exclude-Listing is for the KCM to not show them IIRC, but not for KWin. Anyway the KCMs need to be ported to KPackage, it's just legacy, let's not add more porting work to new code. I would appreciate if that could be changed to packages here. | |