Import UriHandler code from KdepimDBusInterfaces
ClosedPublic

Authored by dvratil on May 8 2020, 7:32 PM.

Details

Summary

The code has been largely adapted and improved to better handle all URLs
and to not rely on DBus interfaces and/or directly linking against some
other PIM libraries. Instead, invocation happens through
KRun using the "view" services of KMail, KAddressbook and KOrganizer.

The code is used by calendaring apps to handle opening links to attachments.

Diff Detail

Repository
R75 PIM: Calendar Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.May 8 2020, 7:32 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 8 2020, 7:32 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dvratil requested review of this revision.May 8 2020, 7:32 PM
winterz added a subscriber: winterz.May 8 2020, 7:47 PM
winterz added inline comments.
src/urihandler.cpp
3

remove

38

using CalendarSupport namespace?

src/urihandler.h
3

remove

30

I don't see this being used at all.

35

put into the CalendarSupport namespace

dvratil updated this revision to Diff 82315.May 8 2020, 8:33 PM
dvratil marked 5 inline comments as done.
  • Address review comments
winterz accepted this revision.May 8 2020, 8:53 PM
This revision is now accepted and ready to land.May 8 2020, 8:53 PM
This revision was automatically updated to reflect the committed changes.