Add --view option to display incidence
ClosedPublic

Authored by dvratil on May 8 2020, 2:10 PM.

Details

Summary

Similar to kmail --view, this opens only the incidence viewer with the specified
incidence. Also introduces korganizer-view service to allow opening the URL
through a desktop file.

Test Plan

korganizer --view "akonadi://?item=<some-incidence-item-akonadi-id>"

Diff Detail

Repository
R210 KOrganizer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.May 8 2020, 2:10 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 8 2020, 2:10 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dvratil requested review of this revision.May 8 2020, 2:10 PM
dvratil updated this revision to Diff 82270.May 8 2020, 2:24 PM
  • Fix wrong default for showing the main window
winterz accepted this revision.May 8 2020, 2:45 PM
winterz added a subscriber: winterz.

(minor) English wording could be improved a bit. otherwise lgtm

src/koapp.cpp
92

"Failed to retrieve incidence from Akonadi: requested incidence does not exist."

src/korganizer-view.desktop
4

Display incidence specified by URL?

src/korganizer_options.h
42

"Display the specified incidence (by url)" maybe?

This revision is now accepted and ready to land.May 8 2020, 2:45 PM
dvratil marked 3 inline comments as done.May 8 2020, 8:29 PM
dvratil updated this revision to Diff 82312.May 8 2020, 8:29 PM
  • Address review comments
This revision was automatically updated to reflect the committed changes.