Differential D2946

make sure allTimezones is set
ClosedPublic
Actions

Authored by mart on Oct 5 2016, 1:56 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R871:4e5d70d8b5d1: make sure allTimezones is set
R120:4e5d70d8b5d1: make sure allTimezones is set
R120:e88b52a18ff9: make sure allTimezones is set
R871:e88b52a18ff9: make sure allTimezones is set
Summary

on Qt 5.6/5.7 changed signal was emitted at startup as well,
triggering plasmoid.configuration.onSelectedTimeZonesChanged
in Qt 5.8 this doesn't happen, giving an empty clock at startup
this makes sure allTimezones gets built

Test Plan

with Qt 5.8 the clock is shown correctly

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart updated this revision to Diff 7117.Oct 5 2016, 1:56 PM
mart retitled this revision from to make sure allTimezones is set.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 5 2016, 1:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Oct 5 2016, 2:51 PM
broulik added a reviewer: broulik.
broulik added a subscriber: broulik.

So they changed the behavior of QQmlPropertyMap when a property is inserted that previously didn't exist?

applets/digital-clock/package/contents/ui/main.qml
45 ↗(On Diff #7117)

Prefer [] over Array()

This revision is now accepted and ready to land.Oct 5 2016, 2:51 PM
Closed by commit R120:e88b52a18ff9: make sure allTimezones is set (authored by mart). · Explain WhyOct 6 2016, 8:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7133

View Options

applets/digital-clock/package/contents/ui/main.qml

Loading...