Differential D2935

Improve ksmserver debug output
ClosedPublic
Actions

Authored by oliverhenshaw on Oct 4 2016, 2:46 PM.

Tags

Subscribers

Details

Reviewers

Commits

R120:1531c7688315: Improve ksmserver debug output
R871:1531c7688315: Improve ksmserver debug output

Summary

Correct misleading debug output. Make all ksmserver output (apart from the tests) controllable with QLoggingCategory.

Test Plan

Compiled, logged in and out both with & without "ksmserver.debug=true" in qtlogging.ini

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

oliverhenshaw updated this revision to Diff 7090.Oct 4 2016, 2:46 PM

oliverhenshaw retitled this revision from to Improve ksmserver debug output.

oliverhenshaw updated this object.

oliverhenshaw edited the test plan for this revision. (Show Details)

oliverhenshaw set the repository for this revision to R120 Plasma Workspace.

Restricted Application added a project: Plasma. · View Herald TranscriptOct 4 2016, 2:46 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Add patch 2 - Use QLoggingCategory more in ksmerver

Add patch 3 - Use QLoggingCategory in ksmserver-logout-greeter

davidedmundson accepted this revision.Oct 4 2016, 2:50 PM

davidedmundson added a reviewer: davidedmundson.

This revision is now accepted and ready to land.Oct 4 2016, 2:50 PM

Closed by commit R120:1531c7688315: Improve ksmserver debug output (authored by oliverhenshaw). · Explain WhyOct 4 2016, 4:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			ksmserver/client.cpp (2 lines)
M			ksmserver/logout-greeter/CMakeLists.txt (2 lines)
M			ksmserver/main.cpp (7 lines)
M			ksmserver/server.cpp (16 lines)
M			ksmserver/shutdown.cpp (18 lines)
M			ksmserver/shutdowndlg.cpp (6 lines)
M			ksmserver/startup.cpp (10 lines)
M			ksmserver/switchuserdialog.cpp (5 lines)

Diff 7096

ksmserver/client.cpp

Loading...

ksmserver/logout-greeter/CMakeLists.txt

Loading...

ksmserver/main.cpp

Loading...

ksmserver/server.cpp

Loading...

ksmserver/shutdown.cpp

Loading...

ksmserver/shutdowndlg.cpp

Loading...

ksmserver/startup.cpp

Loading...

ksmserver/switchuserdialog.cpp

Loading...