Differential D29310

Change NoLogo Type to uint16_t to fix windows build
ClosedPublic
Actions

Authored by tfella on Apr 30 2020, 6:00 PM.

Details

Reviewers
vkrause
Commits
R1032:a1a14ea4d308: Change NoLogo Type to uint16_t to fix windows build
Summary

The MSVC 2017 build is broken because of errors in data type conversion. Setting the type to uint16_t explicitely fixes these errors.

Test Plan

Compiles and works on MSVC 2017, gcc, clang

Diff Detail

Repository
R1032 KPublicTransport
Branch
WindowsFix (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26154
Build 26172: arc lint + arc unit
tfella requested review of this revision.Apr 30 2020, 6:00 PM
tfella created this revision.
vkrause accepted this revision.Apr 30 2020, 6:31 PM
This revision is now accepted and ready to land.Apr 30 2020, 6:31 PM
Closed by commit R1032:a1a14ea4d308: Change NoLogo Type to uint16_t to fix windows build (authored by tfella). · Explain WhyApr 30 2020, 7:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81616

View Options

src/generator/generator.cpp

Loading...
View Options

src/lib/knowledgedb/linemetadata_data.cpp

Loading...