Home
Phabricator
Search
Log In
Differential
D29301
[applets/mediacontroller] Elide text
Closed
Public
Actions
Authored by
cblack
on Apr 30 2020, 3:02 PM.
Edit Revision
Update Diff
Download Raw Diff
Edit Related Revisions...
Edit Parent Revisions
Edit Child Revisions
Edit Related Objects...
Edit Commits
Edit Tasks
Subscribe
Mute Notifications
Award Token
Flag For Later
Tags
Plasma
Subscribers
ngraham
,
plasma-devel
Details
Reviewers
broulik
ngraham
Group Reviewers
VDG
Commits
R120:0dcc58a10628: [applets/mediacontroller] Elide text
Test Plan
Before:
After:
Diff Detail
Left (Diff 81593)
Right (Diff 81598)
Repository
R120 Plasma Workspace
Branch
cblack/layout-fixeroni (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26138
Build 26156: arc lint + arc unit
Repository
R120 Plasma Workspace
Branch
cblack/layout-fixeroni (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26142
Build 26160: arc lint + arc unit
cblack
created this revision.
Apr 30 2020, 3:02 PM
Restricted Application
added a project:
Plasma
.
·
View Herald Transcript
Apr 30 2020, 3:02 PM
Restricted Application
added a subscriber:
plasma-devel
.
·
View Herald Transcript
cblack
requested review of this revision.
Apr 30 2020, 3:02 PM
Harbormaster
completed remote builds in
B26138: Diff 81593
.
Apr 30 2020, 3:02 PM
ngraham
requested changes to this revision.
Apr 30 2020, 3:04 PM
ngraham
added a subscriber:
ngraham
.
Comment Actions
That ain't gonna work
This revision now requires changes to proceed.
Apr 30 2020, 3:04 PM
cblack
updated this revision to
Diff 81598
.
Apr 30 2020, 3:55 PM
cblack
retitled this revision from
[applets/mediacontroller] Drop maximum height on songTitle
to
[applets/mediacontroller] Elide text
.
cblack
edited the test plan for this revision.
(Show Details)
Comment Actions
Elide text
Harbormaster
completed remote builds in
B26142: Diff 81598
.
Apr 30 2020, 3:55 PM
ngraham
accepted this revision.
Apr 30 2020, 5:45 PM
Comment Actions
Much better, thanks.
This revision is now accepted and ready to land.
Apr 30 2020, 5:45 PM
broulik
accepted this revision.
May 1 2020, 12:43 PM
Closed by commit
R120:0dcc58a10628: [applets/mediacontroller] Elide text
(authored by
cblack
).
·
Explain Why
May 1 2020, 12:47 PM
This revision was automatically updated to reflect the committed changes.