Differential D2927

Don't create attached LayoutMirroring on non Item
ClosedPublic
Actions

Authored by davidedmundson on Oct 4 2016, 7:51 AM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R119:3dd03afd37a3: Don't create attached LayoutMirroring on non Item
Summary

The current code tries checking if we're in RTL on the current object,
but is accidentally reading an attached property on the Translate object
rather than the root Item. This gives a warning, and more importantly
won't work.

BUG: 369836

Test Plan

Ran plasmsa and opened applet handle
Ran plasmashell --reverse and opened applet handle

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 7074.Oct 4 2016, 7:51 AM
davidedmundson retitled this revision from to Don't create attached LayoutMirroring on non Item.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 4 2016, 7:51 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Oct 4 2016, 7:52 AM
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.Oct 4 2016, 7:52 AM
Closed by commit R119:3dd03afd37a3: Don't create attached LayoutMirroring on non Item (authored by davidedmundson). · Explain WhyOct 4 2016, 8:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7075

View Options

containments/desktop/package/contents/ui/AppletHandle.qml

Loading...