Differential D2926

Fix wrong logic in "Next/Previous Tool View"
ClosedPublic
Actions

Authored by antonanikin on Oct 4 2016, 7:32 AM.

Details

Reviewers
apol
Group Reviewers
KDevelop
Commits
R33:24d3e3bb869b: Fix wrong logic in "Next/Previous Tool View"
R32:24d3e3bb869b: Fix wrong logic in "Next/Previous Tool View"
Summary

Old version has broken logic:

  1. Select any element from Left/Right dock (Tool View)
  2. Select "Window->Next Tool View"
  3. As a result previous element will be shown (elements are switched from bottom to top).
Test Plan

Tested on master and 5.0 branches.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
antonanikin updated this revision to Diff 7073.Oct 4 2016, 7:32 AM
antonanikin retitled this revision from to Fix wrong logic in "Next/Previous Tool View".
antonanikin updated this object.
antonanikin edited the test plan for this revision. (Show Details)
antonanikin added a reviewer: KDevelop.
antonanikin set the repository for this revision to R33 KDevPlatform.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptOct 4 2016, 7:32 AM
apol accepted this revision.Oct 4 2016, 11:08 AM
apol added a reviewer: apol.
This revision is now accepted and ready to land.Oct 4 2016, 11:08 AM
antonanikin added a comment.Oct 4 2016, 11:09 AM

Push it to 5.0 branch?

antonanikin planned changes to this revision.Oct 5 2016, 6:19 AM
brauch added a subscriber: brauch.Oct 5 2016, 6:31 AM

For something that can obviously be considered a bug fix like this, yes, 5.0 please. For features or feature-like changes, I'd suggest master at this point.

antonanikin updated this revision to Diff 7110.Oct 5 2016, 9:19 AM
antonanikin updated this object.
antonanikin edited the test plan for this revision. (Show Details)
antonanikin edited edge metadata.
This revision is now accepted and ready to land.Oct 5 2016, 9:19 AM
Closed by commit R33:24d3e3bb869b: Fix wrong logic in "Next/Previous Tool View" (authored by antonanikin). · Explain WhyOct 5 2016, 9:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msublime/idealcontroller.cpp (27 lines)

Diff 7111

View Options

sublime/idealcontroller.cpp

Loading...