Differential D29235

Switched SmallIcon with QIcon overloads
ClosedPublic
Actions

Authored by hellozee on Apr 27 2020, 4:58 PM.

Details

Reviewers
ognarb
niccolove
Commits
R1050:575703f95c91: Switched SmallIcon with QIcon overloads
Summary

According to KIConThemes API docs SmallIcon was deprecated in favor of QICon with standard sizes.

Test Plan

The document save should show up in the status bar without any difference, haven't tested the encrypted icon, since I have no idea how to test it in the first place. So need some help there.

Diff Detail

Repository
R1050 BasKet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hellozee requested review of this revision.Apr 27 2020, 4:58 PM
hellozee created this revision.
ognarb accepted this revision.Apr 27 2020, 5:01 PM

LGTM

This revision is now accepted and ready to land.Apr 27 2020, 5:01 PM
niccolove accepted this revision.Apr 27 2020, 5:17 PM
Closed by commit R1050:575703f95c91: Switched SmallIcon with QIcon overloads (authored by hellozee). · Explain WhyApr 27 2020, 5:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/basketstatusbar.cpp (5 lines)

Diff 81371

View Options

src/basketstatusbar.cpp

Loading...