[Digital Clock] Silence warning
ClosedPublic
Actions

Authored by broulik on Oct 3 2016, 5:50 PM.

Details

Reviewers

eliasp
mart

Group Reviewers

Plasma

Commits

Summary

BUG: 369734
FIXED-IN: 5.8.1

Test Plan

No more warning on startup, timezones in tooltip (both city and abbreviation) still work.

It's not ideal style to read that thing from the compact rep rather than having that logic in the main.qml, though.

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik retitled this revision from to [Digital Clock] Silence warning.

broulik updated this object.

broulik edited the test plan for this revision. (Show Details)

broulik added reviewers: Plasma, eliasp.

broulik set the repository for this revision to R120 Plasma Workspace.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart accepted this revision.Oct 3 2016, 7:27 PM

mart added a reviewer: mart.

This revision is now accepted and ready to land.Oct 3 2016, 7:27 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applets/digital-clock/package/contents/ui/Tooltip.qml (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7065			Oct 3 2016, 5:49 PM	★	★
Diff 2	7115	f3a8845	rPLASMAWORKSPACE27274d4c913d0b7b5cfece0f5e5b14c278f063f9	Oct 5 2016, 1:26 PM	★	★