Differential D29187

T6445 Fix order of the GnuPG option groups
ClosedPublic
Actions

Authored by andreylegayev on Apr 25 2020, 8:17 PM.

Details

Reviewers
dvratil
Maniphest Tasks
T6445: The tab order of the GnuPG options is not stable
Commits
R90:f6da51776969: Fix order of the GnuPG option groups
Summary

Fix random order of GnuPG configuration groups by sorting in pre-defined order.

Test Plan
  1. Build Kleoptra with new version of libkleo
  2. Open Kleopatra configuration window several times.

It can be done from Kleopatra main menu or by running kcmshell5 --desktopfile kleopatra_config_gnupgsystem.desktop kleopatra_config_gnupgsystem

Expected result: order of options groups inside every tab should be the same on every run.

Diff Detail

Repository
R90 PIM: Kleo Library
Lint
Lint Skipped
Unit
Unit Tests Skipped
andreylegayev created this revision.Apr 25 2020, 8:17 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 25 2020, 8:17 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
andreylegayev requested review of this revision.Apr 25 2020, 8:17 PM
andreylegayev added a subscriber: dvratil.

@dvratil Tabs order has been fixed. Now it's about option groups inside every tab.
Could you review it?

I've checked: options order inside every tab is stable.

dvratil accepted this revision.Apr 27 2020, 10:09 AM

Nicely done, thanks for the patch.

This revision is now accepted and ready to land.Apr 27 2020, 10:09 AM
Closed by commit R90:f6da51776969: Fix order of the GnuPG option groups (authored by andreylegayev). · Explain WhyApr 27 2020, 10:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81199

View Options

src/ui/cryptoconfigmodule.h

Loading...
View Options

src/ui/cryptoconfigmodule.cpp

Loading...