[jni-signatures] Also check class and method names
ClosedPublic
Actions

Authored by nicolasfella on Apr 24 2020, 11:48 AM.

Details

Reviewers

Commits

R74:da23a44a6369: [jni-signatures] Also check class and method names

Summary

While not as complex as method signatures there's still potential for errors here, e.g. passing a signature where a name is expected.
This also fixes the check for static methods that didn't take the class name arg into account earlier

Diff Detail

Repository

R74 Clazy

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella requested review of this revision.Apr 24 2020, 11:48 AM

nicolasfella created this revision.

Harbormaster completed remote builds in B25824: Diff 81090.Apr 24 2020, 11:48 AM

smartins accepted this revision.Apr 29 2020, 9:08 PM

This revision is now accepted and ready to land.Apr 29 2020, 9:08 PM

Closed by commit R74:da23a44a6369: [jni-signatures] Also check class and method names (authored by nicolasfella). · Explain WhyMay 1 2020, 7:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/checks/manuallevel/jnisignatures.h (3 lines)
M			src/checks/manuallevel/jnisignatures.cpp (49 lines)
M			tests/jni-signatures/main.cpp (35 lines)
M			tests/jni-signatures/main.cpp.expected (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	81090	579779b		Apr 24 2020, 11:48 AM	★	★
Diff 2	81705	579779b	R74:da23a44a63692bc70ef32e8497cb1d4d40624588	May 1 2020, 7:49 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
cef86ceec3ee	5dd9c7410f31	cfcad8d1883a	Nicolas Fella	work	Apr 24 2020, 11:46 AM
cfcad8d1883a	ee122ab26101	579779bd16dc	Nicolas Fella	Allow specifying error message	Apr 24 2020, 10:23 AM