This adds a footer element that will replace with a possible footer that the contained plasmoid could have, given that they are using a Page.
Details
- Reviewers
ngraham - Maniphest Tasks
- T10470: Improve the visuals of tray popups
- Commits
- R120:0f28094f584c: Add footer support to systray
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 25887 Build 25905: arc lint + arc unit
It helps to add a description, Test Plan, and screenshots. Since there are none, I have to guess at what this patch is doing, and I'm not sure if its failure to remove the extra margins around the footer in the Audio applet are due to a missing other patch, or this patch not working.
It also helps if your reviewer has applied the correct patch before he leaves a snarky comment. :)
I can see now that this is working properly. But please to add more info into the Description and Test Plan sections so they can become a part of the historical record in the git log.
applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml | ||
---|---|---|
38 ↗ | (On Diff #81184) | Nothing was using this? |
Sorry! I'll double check from now on.
applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml | ||
---|---|---|
38 ↗ | (On Diff #81184) | Nothing |
Actually this does something funky to the Vaults applet if I open the sound applet first and then switch to Vaults while the popup is still open:
I see some errors in the console:
file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/PlasmoidPopupsContainer.qml:40: TypeError: Cannot read property 'visible' of undefined file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/PlasmoidPopupsContainer.qml:41: TypeError: Cannot read property 'height' of undefined file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/PlasmoidPopupsContainer.qml:44: TypeError: Cannot read property 'visible' of undefined file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/PlasmoidPopupsContainer.qml:45: TypeError: Cannot read property 'height' of undefined