Fix drag-and-drop extraction of parentless files
ClosedPublic

Authored by rthomsen on Oct 1 2016, 7:06 PM.

Details

Summary

In some archives parent folders of some files might not be part of the archive themselves, i.e. the archive does not contain entries for them. In this case ArchiveModel creates ArchiveDirNodes for these folders. However, the FileName and InternalID properties of these folders do not get a trailing slash. This results in faulty root nodes leading to e.g. broken drag-n-drop extraction of files within these folders.

This diff simply appends a traling slash to the properties.

Solves bug:
https://bugs.kde.org/show_bug.cgi?id=367549

Meant for Applications/16.08 branch.

Test Plan
  1. Open an archive which contains parentless files, e.g. the nested tar.gz archive within the attached archive in: https://bugs.kde.org/show_bug.cgi?id=367549
  2. Drag-and-drop extract e.g. the file etc/nsswitch.conf

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rthomsen updated this revision to Diff 7028.Oct 1 2016, 7:06 PM
rthomsen retitled this revision from to Fix drag-and-drop extraction of parentless files.
rthomsen updated this object.
rthomsen edited the test plan for this revision. (Show Details)
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to R36 Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptOct 1 2016, 7:06 PM
rthomsen updated this object.Oct 1 2016, 7:06 PM
elvisangelaccio accepted this revision.Oct 1 2016, 7:21 PM
elvisangelaccio edited edge metadata.
This revision is now accepted and ready to land.Oct 1 2016, 7:21 PM
This revision was automatically updated to reflect the committed changes.