ColorUtils: Use const ref for QColor/QJSValue, fix code style
ClosedPublic

Authored by ahiemstra on Apr 21 2020, 11:31 AM.

Details

Summary

Use const ref for QColor and QJSValue values.
Clean up code style, lots of missing braces and spaces.
Don't use std::map if no lookup by key actually happens.
std::vector is a much less heavy-weight container.

Test Plan

Things still work.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Apr 21 2020, 11:31 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptApr 21 2020, 11:31 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Apr 21 2020, 11:31 AM
mart accepted this revision.May 4 2020, 9:08 AM
This revision is now accepted and ready to land.May 4 2020, 9:08 AM
This revision was automatically updated to reflect the committed changes.