Differential D2904

Enabled support for application/x-archive
ClosedPublic
Actions

Authored by rthomsen on Oct 1 2016, 10:37 AM.

Details

Reviewers
elvisangelaccio
Commits
R36:c31115752533: Enable support for application/x-archive
Summary

Read-only support for application/x-archive which is mostly used for static libraries (*.a) was enabled in libarchiveplugin.

Due to static libraries containing the two entries "/" and "//", code was added to skip these entries to avoid the "absolute path" error. This enables extraction of this archive type.

Test Plan

Open and extract static libraries.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rthomsen updated this revision to Diff 7021.Oct 1 2016, 10:37 AM
rthomsen retitled this revision from to Enabled support for application/x-archive.
rthomsen updated this object.
rthomsen edited the test plan for this revision. (Show Details)
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to R36 Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptOct 1 2016, 10:37 AM
elvisangelaccio edited edge metadata.Oct 1 2016, 10:39 AM

Please add also a test file + extraction test case :)

elvisangelaccio accepted this revision.Oct 4 2016, 4:23 PM
elvisangelaccio edited edge metadata.

Let's ignore the test case, not worth the trouble with the license issues.. :)

This revision is now accepted and ready to land.Oct 4 2016, 4:23 PM
Closed by commit R36:c31115752533: Enable support for application/x-archive (authored by rthomsen). · Explain WhyOct 4 2016, 8:27 PM
This revision was automatically updated to reflect the committed changes.
rthomsen mentioned this in R36:c31115752533: Enable support for application/x-archive.

Revision Contents
Changeset List

Diff 7101

View Options

plugins/libarchive/CMakeLists.txt

Loading...
View Options

plugins/libarchive/libarchiveplugin.cpp

Loading...