Differential D29010

Wayland: Allow to take single screen screenshots using scale factor without loss
ClosedPublic
Actions

Authored by meven on Apr 20 2020, 2:01 PM.

Details

Reviewers

davidedmundson

Group Reviewers

KWin

Commits

R108:66898e7f46f2: Wayland: Allow to take single screen screenshots using scale factor without loss

Summary

The screenshot made on screens with scale factor were downscaled by their scale factor making them blurry.
It prevents taking screenshots of missing Hidpi related bugs showing the issues under Wayland.

This fix the case of a single screenshot, but not the rest:
Multiscreen screenshot downscales the screen using scale factor.
Spectacle rectangular selection screenshot is broken as soon as some scale factor different than 1 is used on any screen.

Test Plan

Under Wayland with a scale factor on a screen, take a screenshot using spectacle.
The output image is not downscaled and has the same size as the screen resolution.

No other change to any other screenshot mode, or under X.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

meven created this revision.Apr 20 2020, 2:01 PM

Restricted Application added a project: KWin. · View Herald TranscriptApr 20 2020, 2:01 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

meven requested review of this revision.Apr 20 2020, 2:01 PM

Harbormaster completed remote builds in B25520: Diff 80648.Apr 20 2020, 2:01 PM

davidedmundson accepted this revision.Apr 20 2020, 2:03 PM

This revision is now accepted and ready to land.Apr 20 2020, 2:03 PM

Closed by commit R108:66898e7f46f2: Wayland: Allow to take single screen screenshots using scale factor without loss (authored by meven). · Explain WhyApr 20 2020, 2:13 PM

This revision was automatically updated to reflect the committed changes.

meven mentioned this in D25427: [Wayland] Allow to take full resolution screenshot when scaling is used.Apr 20 2020, 3:26 PM

Revision Contents
Changeset List

			Path	Packages
M			effects/screenshot/screenshot.h (3 lines)
M			effects/screenshot/screenshot.cpp (27 lines)
M			libkwineffects/kwineffects.h (9 lines)
M			libkwineffects/kwineffects.cpp (9 lines)
M			plugins/scenes/opengl/scene_opengl.cpp (2 lines)
M			scene.h (2 lines)
M			scene.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	80648	e95d1dc		Apr 20 2020, 2:01 PM	★	★
Diff 2	80649	e95d1dc	R108:66898e7f46f2de13d7ba34f62fb85daf5f21e161	Apr 20 2020, 2:12 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
80fe389a1073	4f8cbbc974c7	e95d1dc95082	Méven Car	Wayland: Allow to take single screen screenshots using scale factor without loss (Show More…)	Apr 20 2020, 1:30 PM