| dfaure |
| Frameworks |
This patch ensures that everything related to headings is undoable
with a single Ctrl+Z. It also adds tests for the following use cases
(ensuring those are undoable with a single undo command):
make && ctest
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/widgets/krichtextedit.cpp | ||
|---|---|---|
| 572 ↗ | (On Diff #80508) | Where is the corresponding beginEditBlock()? |
| src/widgets/krichtextedit.cpp | ||
|---|---|---|
| 572 ↗ | (On Diff #80508) | joinPreviousEditBlock in a way acts as beginEditBlock (see https://doc.qt.io/qt-5/qtextcursor.html#joinPreviousEditBlock). The intent here was following: if user pressed Return, a new line (empty QTextBlock) is inserted somewhere inside QTextEdit::keyPressEvent. I want to also change the cursor style, and I want this action to be treated together with this QTextBlock insertion as a single action in undo stack. That's what joinPreviousEditBlock / endEditBlock combo does (semantically, this "previous edit block" is QTextBlock insertion inside QTextEdit::keyPressEvent) |