Differential D28921

Search for JSON-LD inside of microdata tree
ClosedPublic
Actions

Authored by broulik on Apr 17 2020, 2:31 PM.

Details

Reviewers
vkrause
Commits
R1003:1595b3414a1c: Search for JSON-LD inside of microdata tree
Summary

I've noticed it quite often that websites annotate their <body> as WebPage and then have a <script type="application/ld+json> inside. We would not find such a tag since we're only on the lookout for more microdata once processing one.

Test Plan
  • Existing unittests still pass
  • Comes with a new one to cover this usecase
  • We find NewsArticle annotations in articles on rheinpfalz.de now

Diff Detail

Repository
R1003 KItinerary: Travel Reservation handling library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 17 2020, 2:31 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 17 2020, 2:31 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
broulik requested review of this revision.Apr 17 2020, 2:31 PM
broulik edited the test plan for this revision. (Show Details)Apr 17 2020, 2:33 PM
vkrause accepted this revision.Apr 17 2020, 3:07 PM
This revision is now accepted and ready to land.Apr 17 2020, 3:07 PM
Closed by commit R1003:1595b3414a1c: Search for JSON-LD inside of microdata tree (authored by broulik). · Explain WhyApr 17 2020, 3:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 80399

View Options

autotests/structureddata/empty-microdata-with-json-ld-inside.html

Loading...
View Options

autotests/structureddata/empty-microdata-with-json-ld-inside.json

Loading...
View Options

src/generic/structureddataextractor.cpp

Loading...