Differential D2892

[Image Wallpaper] Hide background color Rectangle if it would not be visible
AbandonedPublic
Actions

Authored by broulik on Sep 30 2016, 8:30 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

There's no point in rendering a colored rectangle behind a full-size wallpaper.

Test Plan

Verified in GammaRay that there's no Rectangle visible behind the wallpaper if I set it to "Scale".

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 6999.Sep 30 2016, 8:30 AM
broulik retitled this revision from to [Image Wallpaper] Hide background color Rectangle if it would not be visible.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 30 2016, 8:30 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik updated this revision to Diff 7000.Sep 30 2016, 8:47 AM
broulik edited the test plan for this revision. (Show Details)

Make logic more robust

davidedmundson added a subscriber: davidedmundson.Sep 30 2016, 1:17 PM

The wallpaper could have an alpha channel

and in 71acecf2e737883cc8f68f4b361e1b3ea9cfe7b6 someone changed the wallpaper config to always show the background colour config for this reason which makes it something we now officially support.

broulik abandoned this revision.Sep 30 2016, 1:44 PM

Revision Contents
Changeset List

Diff 7000

View Options

wallpapers/image/imagepackage/contents/ui/main.qml

Loading...