Differential D28858

[wayland] avoid potential crash when checking for window inhibitions on desktop change
ClosedPublic
Actions

Authored by davidedmundson on Apr 15 2020, 3:49 PM.

Details

Reviewers
apol
Group Reviewers
KWin
Commits
R108:d0875aa11707: [wayland] avoid potential crash when checking for window inhibitions on desktop…
Summary

Xwayland clients are sometimes offset from being visible to having a
surface applied.

We might also have internal windows which will be AbstractClients
without a surface.

No idle interface will be set up for non wayland clients, but on a
desktop change we itterate through all AbstractClients and need to guard
somewhere.

BUG: 420039

Test Plan

None

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Apr 15 2020, 3:49 PM
Restricted Application added a project: KWin. · View Herald TranscriptApr 15 2020, 3:49 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Apr 15 2020, 3:49 PM
apol accepted this revision.Apr 15 2020, 10:35 PM
This revision is now accepted and ready to land.Apr 15 2020, 10:35 PM
Closed by commit R108:d0875aa11707: [wayland] avoid potential crash when checking for window inhibitions on desktop… (authored by davidedmundson). · Explain WhyApr 16 2020, 12:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Midle_inhibition.cpp (2 lines)

Diff 80256

View Options

idle_inhibition.cpp

Loading...