Call updateScripts in KReportDesigner::setScriptSource
ClosedPublic

Authored by jfita on Apr 11 2020, 8:13 PM.

Details

Summary

KReportDesigner already has a slot that calls this function when the page
button is clicked. However, both in the example application as well as in Kexi,
the page is already selected when showing the designer for the first time and,
unless the user presses the page button again, trying to select a script from
the combo box does not display any choice, not even “none”/empty, and it prints
the following warning on the console:

org.kde.kproperty: NO SUCH KEY: "" property= "script"

Diff Detail

Repository
R14 KReport
Branch
update-script-list-on-set (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25081
Build 25099: arc lint + arc unit
jfita created this revision.Apr 11 2020, 8:13 PM
Restricted Application added a project: KReport. · View Herald TranscriptApr 11 2020, 8:13 PM
jfita requested review of this revision.Apr 11 2020, 8:13 PM
staniek accepted this revision.Apr 11 2020, 8:48 PM
staniek added a subscriber: staniek.

Good job!

This revision is now accepted and ready to land.Apr 11 2020, 8:48 PM

BTW @jfita, I propose adding the following line to the description, to help us creating change logs:

FIXED-IN:3.2.1

staniek closed this revision.Apr 11 2020, 8:52 PM