Improve focus handling of internal previewer
ClosedPublic

Authored by rthomsen on Sep 27 2016, 6:31 AM.

Details

Reviewers
elvisangelaccio
Summary

This diff sets the initial focus of the internal previewer to the Part widget and sets the autodefault property of the Close button to false. The latter prevents the Enter key from closing the dialog which allows the Part widget to handle the key press event instead.

Fixes two bugs:
Bug 369401
Bug 369390

Meant for 16.08 branch.

Test Plan
  1. Open any archive and preview a file with internal previewer.
  2. Check that the Part widget has focus.
  3. Check that the Enter key doesn't close the dialog.

Diff Detail

Repository
R36 Ark
Lint
Lint Skipped
Unit
Unit Tests Skipped
rthomsen updated this revision to Diff 6943.Sep 27 2016, 6:31 AM
rthomsen retitled this revision from to Improve focus handling of internal previewer.
rthomsen updated this object.
rthomsen edited the test plan for this revision. (Show Details)
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to R36 Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel. ยท View Herald TranscriptSep 27 2016, 6:31 AM
elvisangelaccio accepted this revision.Sep 27 2016, 9:15 AM
elvisangelaccio edited edge metadata.
This revision is now accepted and ready to land.Sep 27 2016, 9:15 AM
rthomsen closed this revision.Sep 28 2016, 10:42 AM

Committed to Applications/16.08 branch with rARK0ec7aa626901.