[plasma-session] Don't prematurely cache systemEnvironemnt
ClosedPublic
Actions

Authored by davidedmundson on Apr 6 2020, 3:13 PM.

Details

Reviewers

None

Group Reviewers

Plasma

Commits

Summary

plasma-session goes to great lengths to make sure we have the latest env
vars from kcminit in future spawned jobs.

However one part got broke in some refactor, we capture the system
environment when we make the job, not when we're about to launch.

This means potentially kded5 and ksmserver wouldn't have the envs
kcminit set.

I've not noticed any practical impact from this.

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

davidedmundson requested review of this revision.Apr 6 2020, 3:13 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 8 2020, 10:54 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			startkde/plasma-session/startup.h (1 line)
M			startkde/plasma-session/startup.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	79492	6dc04ef		Apr 6 2020, 3:13 PM	★	★
Diff 2	79636	5540072	R120:4e681fdb580f32dcebae3857b51d4c0445e3cd97	Apr 8 2020, 10:53 AM	★	★