Install method was copying files directly to craftroot. Files are now properly
copied to craftroot/build/libs/qtav/image-xxx and package gets created
correctly. Changed to CMake build.
Details
- Reviewers
vonreth - Group Reviewers
Craft - Commits
- R877:967b59ee19bf: libs/qtav: fixed package installation
Diff Detail
- Repository
- R877 Craft Blueprints for KDE
- Branch
- qtav
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 24808 Build 24826: arc lint + arc unit
As it looks like the install script sucks... and I expect it to just copy the binaries and some headers...
Can we just do it with our functions?
Like hardcode install file list into python install() method? I can do that if you think it's better.
Install shell scripts are generated here: https://github.com/wang-bin/QtAV/blob/master/tools/install_sdk/install_sdk.pro
What if I generate a patch the replaces QT_INSTALL_LIBS/QT_INSTALL_HEADERS/QT_INSTALL_QML/MKSPECS_DIR there before script?
- libs/qtav: moved to cmake build
Don't shoot me... Think this might be cleaner.
QtAV recently introduced CMake build (which was broken under mingw) so have moved to that.
CMake was unable to find ffmpeg libraries in craft so have added 0004-cmake-fixes.patch from open PR: https://github.com/wang-bin/QtAV/pull/1211
CMake was trying to build EGL stuff which is unavailable on mingw - have corrected that with 0005-cmake-fix-mingw-build.patch
besides the qml install path this looks much more sane.
libs/qtav/0004-cmake-fixes.patch | ||
---|---|---|
5 ↗ | (On Diff #79490) | Sounds wrong, why? |
libs/qtav/0004-cmake-fixes.patch | ||
---|---|---|
5 ↗ | (On Diff #79490) | I should probably remove that... craft's QMLs are installed to CRAFTROOT/qml and not CRAFTROOT/lib/qml Guy mentioned https://api.kde.org/ecm/kde-module/KDEInstallDirs.html#QMLDIR Have checked in KDEInstallDirs.cmake... when KDE_INSTALL_USE_QT_SYS_PATHS is ON it uses qmake's QT_INSTALL_QML, otherwise uses lib/qml Original code used PREFIX/qml |